Skip to content

[PR] Add method signatures to request methods #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iamliuzy
Copy link

@iamliuzy iamliuzy commented Jul 9, 2025

Added some type stubs to core.pyi.

To let Pylance stop warning me that these methods doesn't exist.


name: Pull Request
about: Propose changes to the codebase
title: '[PR] Add method signatures to request methods'
labels: ''
assignees: ''


Related Issue
#319 Although it's fixed, I think this is the best way to solve it.

Proposed Changes
Describe the big picture of your changes here. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

To let Pylance stop warning me that these methods doesn't exist.
Copy link

gitnotebooks bot commented Jul 9, 2025

Review these changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant